ia64/xen-unstable

changeset 11388:030a041bbe90

find changesets by author, revision, files, or words in the commit message
[XEN][POWERPC] cleanup for (;;);

When the port first started, we didn't even have panic() working
properly so we used "for(;;);" loops to stop execution. Now that output
is buffered these look like hangs, since you usually do not see the
printk() before.

Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
author Jimi Xenidis <jimix@watson.ibm.com>
date Tue Aug 29 06:53:58 2006 -0400 (2006-08-29)
parents 3e144748d36f
children 18ce855ff594
files xen/arch/powerpc/dart_u3.c xen/arch/powerpc/external.c xen/arch/powerpc/papr/tce.c
line diff
     1.1 --- a/xen/arch/powerpc/dart_u3.c	Mon Aug 28 17:28:55 2006 -0400
     1.2 +++ b/xen/arch/powerpc/dart_u3.c	Tue Aug 29 06:53:58 2006 -0400
     1.3 @@ -55,10 +55,10 @@ static void u3_inv_all(void)
     1.4          dc.reg.dc_invtlb = 1;
     1.5          out_32(dart_ctl_reg, dc.dc_word);
     1.6  
     1.7 -    do {
     1.8 -        dc.dc_word = in_32(dart_ctl_reg);
     1.9 -        r++;
    1.10 -    } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
    1.11 +        do {
    1.12 +            dc.dc_word = in_32(dart_ctl_reg);
    1.13 +            r++;
    1.14 +        } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
    1.15  
    1.16          if (r == (1 << l)) {
    1.17              if (l < 4) {

     2.1 --- a/xen/arch/powerpc/external.c	Mon Aug 28 17:28:55 2006 -0400
     2.2 +++ b/xen/arch/powerpc/external.c	Tue Aug 29 06:53:58 2006 -0400
     2.3 @@ -175,8 +175,7 @@ void init_IRQ(void)
     2.4  
     2.5  void ack_APIC_irq(void)
     2.6  {
     2.7 -    printk("%s: EOI the whole MPIC?\n", __func__);
     2.8 -    for (;;);
     2.9 +    panic("%s: EOI the whole MPIC?\n", __func__);
    2.10  }
    2.11  
    2.12  void ack_bad_irq(unsigned int irq)

     3.1 --- a/xen/arch/powerpc/papr/tce.c	Mon Aug 28 17:28:55 2006 -0400
     3.2 +++ b/xen/arch/powerpc/papr/tce.c	Tue Aug 29 06:53:58 2006 -0400
     3.3 @@ -47,7 +47,7 @@ static void h_put_tce(struct cpu_user_re
     3.4          regs->gprs[3] = H_Success;
     3.5      }
     3.6  }
     3.7 -    
     3.8 +
     3.9  static void h_get_tce(struct cpu_user_regs *regs)
    3.10  {
    3.11      u32 liobn = regs->gprs[4];
    3.12 @@ -57,7 +57,7 @@ static void h_get_tce(struct cpu_user_re
    3.13      printk("%s: liobn: 0x%x ioba: 0x%lx \n", __func__, liobn, ioba);
    3.14  #endif
    3.15      regs->gprs[3] = H_Function;
    3.16 -    for(;;) ;
    3.17 +    BUG();
    3.18  }
    3.19  
    3.20  static void h_stuff_tce(struct cpu_user_regs *regs)
    3.21 @@ -76,7 +76,7 @@ static void h_stuff_tce(struct cpu_user_
    3.22              count);
    3.23  #endif
    3.24      regs->gprs[3] = H_Function;
    3.25 -    for(;;);
    3.26 +    BUG();
    3.27  }
    3.28     
    3.29  __init_papr_hcall(H_PUT_TCE, h_put_tce);