From fe09cd72aa8ad0bedeee68158190b334c5bca775 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
Date: Wed, 5 Jun 2019 12:31:01 +0200
Subject: [PATCH] qemu_firmware: only set nfeatures on success
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

The field is set just before returning on success.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_firmware.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index f3d89d000d..bf29b10b9a 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -592,8 +592,6 @@ qemuFirmwareFeatureParse(const char *path,
     if (VIR_ALLOC_N(features, nfeatures) < 0)
         return -1;
 
-    fw->nfeatures = nfeatures;
-
     for (i = 0; i < nfeatures; i++) {
         virJSONValuePtr item = virJSONValueArrayGet(featuresJSON, i);
         const char *tmpStr = virJSONValueGetString(item);
-- 
2.39.5