From fb1d33bd7b1415f9fb5ec7e2d9817655c4eda0a5 Mon Sep 17 00:00:00 2001 From: Anthony PERARD Date: Tue, 19 Mar 2019 17:55:22 +0000 Subject: [PATCH] libxl: Pointer on usage of libxl__domain_userdata_lock It is currently difficult to know how/when/why the userdata lock is supposed to be used. Add some pointers to the hotplug comments. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index a3e4b907b7..03e086480c 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -4477,6 +4477,12 @@ void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock); * data store. The registry entry in libxl private data store * is "libxl-json". * Caller must hold user data lock. + * + * Other names used for this lock throughout the libxl code are json_lock, + * libxl__domain_userdata_lock, "libxl-json", data store lock. + * + * See the comment for libxl__ao_device, and "Algorithm for handling device + * removal", for information about using the libxl-json lock / json_lock. */ int libxl__get_domain_configuration(libxl__gc *gc, uint32_t domid, libxl_domain_config *d_config); -- 2.39.5