From f75ea76ffb3226744b03232acd6039cb397a9e07 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Tue, 14 May 2013 18:48:48 +0100 Subject: [PATCH] piix4acpi, xen: Clarify that the qemu_set_irq calls just do an IRQ pulse. The "qemu_cpu_notify" raises and lowers the ACPI SCI line when the vCPU state has changed. Instead of doing the two functions, just use one function that describes exactly what it does. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini Acked-by: George Dunlap (for 4.3 release) (cherry picked from commit e28e06225c4ee8793f935b0f72fe2d944a2d9b50) --- hw/piix4acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/piix4acpi.c b/hw/piix4acpi.c index 54d566bb0..bf916d956 100644 --- a/hw/piix4acpi.c +++ b/hw/piix4acpi.c @@ -834,8 +834,6 @@ int qemu_cpu_add_remove(int cpu, int state) } void qemu_cpu_notify(void) { - if (gpe_state.gpe0_en[0] & 4) { - qemu_set_irq(sci_irq, 1); - qemu_set_irq(sci_irq, 0); - } + if (gpe_state.gpe0_en[0] & 4) + qemu_irq_pulse(sci_irq); } -- 2.39.5