From f5eadd1d9270d61df4a154baa3671bc08b36d3ff Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 16 Oct 2018 16:43:49 +0200 Subject: [PATCH] qemu: blockjob: Remove header dependency on qemu_domain.h MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The blockjob module uses 'qemuDomainAsyncJob' in it's public headers. As I plan adding a new structure containing job data which will need to be included in "qemu_domain.h" it's necessary to break the circular dependency. Convert 'qemuDomainAsyncJob' type to 'int' as it's an enum. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_blockjob.c | 6 +++--- src/qemu/qemu_blockjob.h | 5 ++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 1b7c107ab8..763a28de5b 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -86,7 +86,7 @@ static void qemuBlockJobEventProcess(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainDiskDefPtr disk, - qemuDomainAsyncJob asyncJob, + int asyncJob, int type, int status) { @@ -210,7 +210,7 @@ qemuBlockJobEventProcess(virQEMUDriverPtr driver, */ int qemuBlockJobUpdateDisk(virDomainObjPtr vm, - qemuDomainAsyncJob asyncJob, + int asyncJob, virDomainDiskDefPtr disk, char **error) { @@ -270,7 +270,7 @@ qemuBlockJobSyncBeginDisk(virDomainDiskDefPtr disk) */ void qemuBlockJobSyncEndDisk(virDomainObjPtr vm, - qemuDomainAsyncJob asyncJob, + int asyncJob, virDomainDiskDefPtr disk) { VIR_DEBUG("disk=%s", disk->dst); diff --git a/src/qemu/qemu_blockjob.h b/src/qemu/qemu_blockjob.h index 5d2459635e..0b28a6fa57 100644 --- a/src/qemu/qemu_blockjob.h +++ b/src/qemu/qemu_blockjob.h @@ -24,16 +24,15 @@ # include "internal.h" # include "qemu_conf.h" -# include "qemu_domain.h" int qemuBlockJobUpdateDisk(virDomainObjPtr vm, - qemuDomainAsyncJob asyncJob, + int asyncJob, virDomainDiskDefPtr disk, char **error); void qemuBlockJobSyncBeginDisk(virDomainDiskDefPtr disk); void qemuBlockJobSyncEndDisk(virDomainObjPtr vm, - qemuDomainAsyncJob asyncJob, + int asyncJob, virDomainDiskDefPtr disk); #endif /* LIBVIRT_QEMU_BLOCKJOB_H */ -- 2.39.5