From f56629ab93747efcd815b4e14cefabf8a98bc0b7 Mon Sep 17 00:00:00 2001 From: Simon Kuenzer Date: Thu, 27 Jul 2023 12:56:27 +0200 Subject: [PATCH] support/qemu-guest: Remove SGA bios parameter and warning Starting with QEMU version 8.0, the `-device sga` parameter is removed from the command line because it is no longer needed. These versions include a SeaBIOS version that contains native support for serial consoles. If an older version of QEMU is used with `qemu-guest`, the BIOS output may no longer be visible but the guest would still be able to boot. Signed-off-by: Simon Kuenzer Reviewed-by: Alexander Jung Approved-by: Razvan Deaconescu Tested-by: Unikraft CI GitHub-Closes: #1034 --- support/scripts/qemu-guest | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/support/scripts/qemu-guest b/support/scripts/qemu-guest index ec43cc557..fba582d8e 100755 --- a/support/scripts/qemu-guest +++ b/support/scripts/qemu-guest @@ -427,9 +427,6 @@ if [ -z "$( which uuidgen )" ]; then echo "Please install uuidgen" 1>&2 exit 2 fi -if [ ! -f "/usr/share/qemu/sgabios.bin" ]; then - echo "Could not find '/usr/share/qemu/sgabios.bin'. This script might not work properly." 1>&2 -fi mkdir -p "${TEMP}" if [ $? -ne 0 ]; then echo "Error: Could not create ${TEMP}" 1>&2 @@ -763,10 +760,6 @@ case "$ARG_MACHINETYPE" in QEMU_BASE_ARGS+=("-cpu") QEMU_BASE_ARGS+=("qemu64,-vmx,-svm,+x2apic,+pdpe1gb") fi - - # BIOS also on serial - QEMU_ARGS+=("-device") - QEMU_ARGS+=("sga") ;; "x86q35") QEMU_BIN=${QEMU_BIN:-"$( which qemu-system-x86_64 )"} @@ -784,10 +777,6 @@ case "$ARG_MACHINETYPE" in QEMU_BASE_ARGS+=("-cpu") QEMU_BASE_ARGS+=("qemu64,-vmx,-svm,+x2apic,+pdpe1gb") fi - - # BIOS also on serial - QEMU_ARGS+=("-device") - QEMU_ARGS+=("sga") ;; *) echo "Unsupported machine type (-t)" -- 2.39.5