From f25dce4a2adf518678280495712d66e627adec1e Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Wed, 14 Feb 2018 08:16:00 +0100 Subject: [PATCH] firmware/shim: avoid mkdir error during Xen tree setup MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit "mkdir -p" reports a missing operand, as config/ has no subdirs. Oddly enough this doesn't cause the whole command (and hence the build to fail), despite the "set -e" now covering the entire set of commands - perhaps a quirk of the relatively old bash I've seen this with (a few simple experiments suggest that commands inside () producing a non- success status would exit the inner shell, but not the outer one). Add a dummy . argument to the invocation. Suggested-by: Wei Liu Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Wei Liu --- tools/firmware/xen-dir/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile index 04d3c936ea..7fd36a0e15 100644 --- a/tools/firmware/xen-dir/Makefile +++ b/tools/firmware/xen-dir/Makefile @@ -22,7 +22,7 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE (mkdir -p $(D)/$(d); \ cd $(D)/$(d); \ find $(XEN_ROOT)/$(d)/ -type d |\ - sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p);) \ + sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p .);) \ $(foreach d, $(LINK_DIRS), \ (cd $(XEN_ROOT); \ find $(d) ! -type l -type f \ -- 2.39.5