From efd2ff999df72ee4c246927fd4297e3a75cadbf3 Mon Sep 17 00:00:00 2001 From: Seraphime Kirkovski Date: Tue, 4 Apr 2017 14:40:48 +0200 Subject: [PATCH] libxc: fix segfault on uninitialized xch->fmem Currently in xc_interface_open, xch->fmem is not initialized and in some rare case the code fails before ever assigning a value to it. I got this in master: $ sudo ./xl/xl run xencall: error: Could not obtain handle on privileged command interface: No such file or directory Segmentation fault This initializes the whole xch_buff to 0. Signed-off-by: Seraphime Kirkovski Acked-by: Wei Liu (cherry picked from commit c4bdbec00c9063736361124a3492ebceabfaed06) --- tools/libxc/xc_private.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index 9ba4b73229..7bea1c555d 100644 --- a/tools/libxc/xc_private.c +++ b/tools/libxc/xc_private.c @@ -30,7 +30,7 @@ struct xc_interface_core *xc_interface_open(xentoollog_logger *logger, xentoollog_logger *dombuild_logger, unsigned open_flags) { - struct xc_interface_core xch_buf, *xch = &xch_buf; + struct xc_interface_core xch_buf = { 0 }, *xch = &xch_buf; xch->flags = open_flags; xch->dombuild_logger_file = 0; -- 2.39.5