From ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Mon, 11 May 2015 21:24:36 +0100 Subject: [PATCH] Document that virNodeGetInfo can return mhz == 0. On the s/390x architecture, libvirt may already return 0 in the node_info->mhz field (see src/nodeinfo.c:linuxNodeInfoCPUPopulate). We may also want to return this on aarch64 in future, because calculating the proper value requires SMBIOS, which is not available on non-server-class systems (specifically on systems which don't adhere to the SBSA standard). Therefore this change documents the existing behaviour and provides a valid path for aarch64. Signed-off-by: Richard W.M. Jones Bug-URL: https://bugzilla.redhat.com/1206353 --- include/libvirt/libvirt-host.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 953366baa..070550bfd 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -354,7 +354,8 @@ struct _virNodeInfo { char model[32]; /* string indicating the CPU model */ unsigned long memory; /* memory size in kilobytes */ unsigned int cpus; /* the number of active CPUs */ - unsigned int mhz; /* expected CPU frequency */ + unsigned int mhz; /* expected CPU frequency, 0 if not known or + on unusual architectures */ unsigned int nodes; /* the number of NUMA cell, 1 for unusual NUMA topologies or uniform memory access; check capabilities XML for the actual NUMA topology */ -- 2.39.5