From e962bea4db167113d1bd4e640888c261763f9dd1 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 4 Mar 2015 18:02:56 +0000 Subject: [PATCH] cirrus: don't overflow CirrusVGAState->cirrus_bltbuf This is CVE-2014-8106. Signed-off-by: Gerd Hoffmann Signed-off-by: Stefano Stabellini --- hw/cirrus_vga.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 3e2f1b252..a5e538f73 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -282,6 +282,10 @@ static bool blit_is_unsafe(struct CirrusVGAState *s) assert(s->cirrus_blt_width > 0); assert(s->cirrus_blt_height > 0); + if (s->cirrus_blt_width > CIRRUS_BLTBUFSIZE) { + return true; + } + if (blit_region_is_unsafe(s, s->cirrus_blt_dstpitch, s->cirrus_blt_dstaddr & s->cirrus_addr_mask)) { return true; -- 2.39.5