From e757f535066061b15cae2b7130a82b15852efa84 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Thu, 20 Mar 2025 13:33:52 +0100 Subject: [PATCH] x86/hvm: check return code of hvm_pi_update_irte when binding MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Consume the return code from hvm_pi_update_irte(), and propagate the error back to the caller if hvm_pi_update_irte() fails. Fixes: 35a1caf8b6b5 ('pass-through: update IRTE according to guest interrupt config changes') Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich master commit: cb587f620ab56cc683347d8120ba63989fad2693 master date: 2025-03-12 13:32:31 +0100 --- xen/drivers/passthrough/x86/hvm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index f73292fd6c..6813107648 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -381,7 +381,15 @@ int pt_irq_create_bind( /* Use interrupt posting if it is supported. */ if ( iommu_intpost ) - hvm_pi_update_irte(vcpu, info, pirq_dpci->gmsi.gvec); + { + rc = hvm_pi_update_irte(vcpu, info, pirq_dpci->gmsi.gvec); + + if ( rc ) + { + pt_irq_destroy_bind(d, pt_irq_bind); + return rc; + } + } if ( pt_irq_bind->u.msi.gflags & XEN_DOMCTL_VMSI_X86_UNMASKED ) { -- 2.39.5