From e6af340b9e32e78fd980d46d939aa0939f51ebd4 Mon Sep 17 00:00:00 2001 From: Kaifeng Zhu Date: Fri, 7 Mar 2014 15:27:36 +0000 Subject: [PATCH] qemu-char: fix memory leak in qemu_char_open_pty() The momery pointed by s and chr could be leaked if openpty return a value less then 0. Signed-off-by: Kaifeng Zhu Coverity-IDs: 1055926 1055927 Reviewed-by: Andrew Cooper --- qemu-char.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 324ed16ec..f62a6afb7 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -932,6 +932,8 @@ static CharDriverState *qemu_chr_open_pty(void) s = qemu_mallocz(sizeof(PtyCharDriver)); if (openpty(&s->fd, &slave_fd, pty_name, NULL, NULL) < 0) { + qemu_free(s); + qemu_free(chr); return NULL; } -- 2.39.5