From d5eda5dfaa49cccb47b7940efe0534593d73592e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Tue, 23 May 2023 15:02:50 +0200 Subject: [PATCH] iommu/amd-vi: fix assert comparing boolean to enum MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Or else when iommu_intremap is set to iommu_intremap_full the assert triggers. Fixes: 1ba66a870eba ('AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode') Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich master commit: 4c507d8a6b6e8be90881a335b0a66eb28e0f7737 master date: 2023-05-12 09:35:36 +0200 --- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 4792b34bc2..e5e0f00402 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -240,7 +240,7 @@ static int __must_check amd_iommu_setup_domain_device( */ if ( dte->it_root ) ASSERT(dte->int_ctl == IOMMU_DEV_TABLE_INT_CONTROL_TRANSLATED); - ASSERT(dte->iv == iommu_intremap); + ASSERT(dte->iv == !!iommu_intremap); ASSERT(dte->ex == ivrs_dev->dte_allow_exclusion); ASSERT(dte->sys_mgt == MASK_EXTR(ivrs_dev->device_flags, ACPI_IVHD_SYSTEM_MGMT)); -- 2.39.5