From cfc28c66f9a754bb589b24e1d503eba2bdc5c840 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 11 Nov 2013 16:37:16 +0100 Subject: [PATCH] qemuDomainObjStart: Warn on corrupted image If the managedsave image is corrupted, e.g. the XML part is, we fail to parse it and throw an error, e.g.: error: Failed to start domain jms8 error: XML error: missing security model when using multiple labels This is okay, as we can't really start the machine and avoid undefined qemu behaviour. On the other hand, the error message doesn't give a clue to users what should they do. The consensus here would be to thrown a warning to logs saying "Hey, you've got a corrupted file". Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9c3daad4ad..ef1359c4c2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6039,10 +6039,13 @@ qemuDomainObjStart(virConnectPtr conn, vm->hasManagedSave = false; } - if (ret > 0) + if (ret > 0) { VIR_WARN("Ignoring incomplete managed state %s", managed_save); - else + } else { + VIR_WARN("Unable to restore from managed state %s. " + "Maybe the file is corrupted?", managed_save); goto cleanup; + } } } -- 2.39.5