From cb28fa605289968ecd7654718a8d5c2886a6a639 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 29 Apr 2024 09:38:47 +0200 Subject: [PATCH] x86/MTRR: correct inadvertently inverted WC check MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The ! clearly got lost by mistake. Fixes: e9e0eb30d4d6 ("x86/MTRR: avoid several indirect calls") Reported-by: Marek Marczykowski-Górecki Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné master commit: 77e25f0e30ddd11e043e6fce84bf108ce7de5b6f master date: 2024-04-23 14:13:48 +0200 --- xen/arch/x86/cpu/mtrr/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c index dee59ea168..990f12286a 100644 --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -316,7 +316,7 @@ int mtrr_add_page(unsigned long base, unsigned long size, } /* If the type is WC, check that this processor supports it */ - if ((type == MTRR_TYPE_WRCOMB) && mtrr_have_wrcomb()) { + if ((type == MTRR_TYPE_WRCOMB) && !mtrr_have_wrcomb()) { printk(KERN_WARNING "mtrr: your processor doesn't support write-combining\n"); return -EOPNOTSUPP; -- 2.39.5