From c58b105625acf3404d75376b070903139e3346a3 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Wed, 22 Dec 2010 11:15:32 -0700 Subject: [PATCH] Set bitmap size when allocating a bitmap I began noticing a race when reserving VNC ports as described here https://www.redhat.com/archives/libvir-list/2010-November/msg00379.html Turns out that we were not initializing the size field of bitmap struct when allocating the bitmap. This subsequently caused virBitmapSetBit() to fail since bitmap->size is 0, hence we never actually reserved the port. --- src/util/bitmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/bitmap.c b/src/util/bitmap.c index 1b0c9da09d..974166890d 100644 --- a/src/util/bitmap.c +++ b/src/util/bitmap.c @@ -73,6 +73,7 @@ virBitmapPtr virBitmapAlloc(size_t size) return NULL; } + bitmap->size = size; return bitmap; } -- 2.39.5