From c3568ec2892c420c931c018719974c01000a18f3 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Fri, 3 Dec 2010 15:02:01 -0700 Subject: [PATCH] virExec: avoid undefined behavior * src/util/util.c (__virExec): Don't use FD_ISSET on out-of-bounds fd. --- src/util/util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 79ca5d3e8a..1b5bc68d68 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -570,8 +570,7 @@ __virExec(const char *const*argv, i != null && i != childout && i != childerr && - (!keepfd || - !FD_ISSET(i, keepfd))) { + (!keepfd || (i < FD_SETSIZE && !FD_ISSET(i, keepfd)))) { tmpfd = i; VIR_FORCE_CLOSE(tmpfd); } -- 2.39.5