From c33e14abb1aea6769146346f6737288be838f906 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 17 Jan 2025 08:53:27 +0100 Subject: [PATCH] xentrace: free CPU mask string before overwriting pointer While multiple -c options may be unexpected, we'd still better deal with them properly. Also restore the blank line that was bogusly zapped by the same commit. Coverity-ID: 1638723 Fixes: e4ad2836842a ("xentrace: Implement cpu mask range parsing of human values (-c)") Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Acked-by: Anthony PERARD Release-Acked-by: Oleksii Kurochko --- tools/xentrace/xentrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index 63b29f8442..a5aa3c1903 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -1105,8 +1105,10 @@ static void parse_args(int argc, char **argv) break; case 'c': /* set new cpu mask for filtering (when xch is set). */ + free(opts.cpu_mask_str); opts.cpu_mask_str = strdup(optarg); break; + case 'e': /* set new event mask for filtering*/ parse_evtmask(optarg); break; -- 2.39.5