From bb15ac459969133fb1d9d3bbfe10b02b6e6405bd Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 9 Nov 2017 10:13:26 +0100 Subject: [PATCH] qemu: block: Break out early on invalid storage sources Return NULL right away in qemuBlockStorageSourceGetBackendProps when an invalid storage source is presented so that virJSONValueObjectAdd isn't called with a NULL argument. Found by coverity. --- src/qemu/qemu_block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index e46a455af8..600f315fea 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -958,7 +958,7 @@ qemuBlockStorageSourceGetBackendProps(virStorageSourcePtr src) case VIR_STORAGE_TYPE_VOLUME: case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: - break; + return NULL; case VIR_STORAGE_TYPE_NETWORK: switch ((virStorageNetProtocol) src->protocol) { @@ -1008,7 +1008,7 @@ qemuBlockStorageSourceGetBackendProps(virStorageSourcePtr src) case VIR_STORAGE_NET_PROTOCOL_NONE: case VIR_STORAGE_NET_PROTOCOL_LAST: - break; + return NULL; } break; } -- 2.39.5