From afdb3fc901056081e8dd88175a464c86adb639d7 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Fri, 29 Apr 2016 10:43:31 +0200 Subject: [PATCH] cpuGetModels: Fix memory leak on error Signed-off-by: Jiri Denemark --- src/cpu/cpu_ppc64.c | 4 +++- src/cpu/cpu_x86.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 364c8ed082..1aed984e90 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -886,8 +886,10 @@ ppc64DriverGetModels(char ***models) if (VIR_STRDUP(name, model->name) < 0) goto error; - if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) + if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) { + VIR_FREE(name); goto error; + } } else { nmodels++; } diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index b7f16903c0..c6aacc1463 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2219,8 +2219,10 @@ x86GetModels(char ***models) if (VIR_STRDUP(name, model->name) < 0) goto error; - if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) + if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) { + VIR_FREE(name); goto error; + } } else { nmodels++; } -- 2.39.5