From a47fb6b9ad382ae572740bb90908bb01b70f5f9b Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 9 May 2011 10:02:19 +0100 Subject: [PATCH] xen/blkfront: fix data size for xenbus_gather in connect() From: Marek Marczykowski barrier variable is int, not long. This overflow caused another variable override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The latter caused incorrect device flags (RO/removable etc). Signed-off-by: Marek Marczykowski Acked-by: Ian Campbell Signed-off-by: Jan Beulich --- drivers/xen/blkfront/blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/blkfront/blkfront.c b/drivers/xen/blkfront/blkfront.c index fdf43b75..92d97761 100644 --- a/drivers/xen/blkfront/blkfront.c +++ b/drivers/xen/blkfront/blkfront.c @@ -360,7 +360,7 @@ static void connect(struct blkfront_info *info) } err = xenbus_gather(XBT_NIL, info->xbdev->otherend, - "feature-barrier", "%lu", &info->feature_barrier, + "feature-barrier", "%d", &info->feature_barrier, NULL); if (err) info->feature_barrier = 0; -- 2.39.5