From 9fe5267adecc6c87074ce673626a73ea4d9f2d6e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Thu, 3 Apr 2014 19:38:54 +0200 Subject: [PATCH] Check maximum startcpu value correctly The cpus are indexed from 0, so a startcpu value equal to the number of CPUs is invalid. https://bugzilla.redhat.com/show_bug.cgi?id=1070680 --- src/util/vircgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index de572764e..2272bc65b 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -2928,10 +2928,10 @@ virCgroupGetPercpuStats(virCgroupPtr group, goto cleanup; } - if (start_cpu > total_cpus) { + if (start_cpu >= total_cpus) { virReportError(VIR_ERR_INVALID_ARG, _("start_cpu %d larger than maximum of %d"), - start_cpu, total_cpus); + start_cpu, total_cpus - 1); goto cleanup; } -- 2.39.5