From 9ba4c529985a1773852069889a5b53f2ed26c408 Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Wed, 23 Feb 2022 19:08:33 +0000 Subject: [PATCH] xen/mm: pg_offlined can be defined as bool in free_heap_pages() The local variable pg_offlined in free_heap_pages() can only take two values. So switch it to a bool. Fixes: 289610483fc43 ("mm: fix broken tainted value in mark_page_free") Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- xen/common/page_alloc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e971bf91e0..319029140f 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1437,8 +1437,9 @@ static void free_heap_pages( { unsigned long mask; mfn_t mfn = page_to_mfn(pg); - unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0; + unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)); unsigned int zone = page_to_zone(pg); + bool pg_offlined = false; ASSERT(order <= MAX_ORDER); @@ -1447,7 +1448,7 @@ static void free_heap_pages( for ( i = 0; i < (1 << order); i++ ) { if ( mark_page_free(&pg[i], mfn_add(mfn, i)) ) - pg_offlined = 1; + pg_offlined = true; if ( need_scrub ) { -- 2.39.5