From 91a00424db7478159bcb5184e397f35c07d0645b Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Sat, 28 Nov 2015 05:33:55 +0100 Subject: [PATCH] xen: use virDomainDefPostParse for parsing XM/XL/SEXPR cofings This change ensures to call driver specific post-parse code to modify domain definition after parsing hypervisor config the same way we do after parsing XML. Signed-off-by: Pavel Hrdina --- src/libxl/libxl_driver.c | 8 ++++++-- src/xen/xen_driver.c | 5 +++-- src/xen/xm_internal.c | 2 +- src/xenconfig/xen_sxpr.c | 16 ++++++++++++++-- src/xenconfig/xen_sxpr.h | 8 ++++++-- src/xenconfig/xen_xl.c | 9 ++++++++- src/xenconfig/xen_xl.h | 4 +++- src/xenconfig/xen_xm.c | 7 ++++++- src/xenconfig/xen_xm.h | 2 +- tests/sexpr2xmldata/sexpr2xml-boot-grub.xml | 1 + tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml | 1 + tests/sexpr2xmldata/sexpr2xml-curmem.xml | 1 + .../sexpr2xml-disk-block-shareable.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-block.xml | 1 + .../sexpr2xml-disk-drv-blktap-qcow.xml | 1 + .../sexpr2xml-disk-drv-blktap-raw.xml | 1 + .../sexpr2xml-disk-drv-blktap2-raw.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-file.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 3 +++ .../sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 3 +++ .../sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml | 2 ++ tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml | 3 +++ .../sexpr2xmldata/sexpr2xml-fv-net-netfront.xml | 3 +++ .../sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml | 3 +++ .../sexpr2xml-fv-serial-dev-2-ports.xml | 3 +++ .../sexpr2xml-fv-serial-dev-2nd-port.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 3 +++ .../sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml | 3 +++ .../sexpr2xml-fv-serial-tcp-telnet.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-fv.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-net-bridged.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-e1000.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-routed.xml | 1 + .../sexpr2xmldata/sexpr2xml-no-source-cdrom.xml | 3 +++ tests/sexpr2xmldata/sexpr2xml-pci-devs.xml | 1 + .../sexpr2xml-pv-bootloader-cmdline.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml | 1 + .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vfb-orig.xml | 1 + .../sexpr2xml-pv-vfb-type-crash.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv.xml | 1 + tests/sexpr2xmltest.c | 10 +++++++++- .../test-fullvirt-direct-kernel-boot.xml | 2 ++ tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 ++ tests/xlconfigdata/test-new-disk.xml | 3 +++ tests/xlconfigdata/test-spice-features.xml | 2 ++ tests/xlconfigdata/test-spice.xml | 2 ++ tests/xlconfigtest.c | 2 +- tests/xmconfigdata/test-escape-paths.xml | 4 ++++ .../test-fullvirt-default-feature.xml | 3 +++ tests/xmconfigdata/test-fullvirt-force-hpet.xml | 3 +++ .../xmconfigdata/test-fullvirt-force-nohpet.xml | 3 +++ tests/xmconfigdata/test-fullvirt-localtime.xml | 3 +++ tests/xmconfigdata/test-fullvirt-net-ioemu.xml | 3 +++ .../xmconfigdata/test-fullvirt-net-netfront.xml | 3 +++ tests/xmconfigdata/test-fullvirt-new-cdrom.xml | 3 +++ tests/xmconfigdata/test-fullvirt-old-cdrom.xml | 3 +++ .../xmconfigdata/test-fullvirt-parallel-tcp.xml | 3 +++ .../test-fullvirt-serial-dev-2-ports.xml | 3 +++ .../test-fullvirt-serial-dev-2nd-port.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-file.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-null.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-pipe.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-pty.xml | 3 +++ .../xmconfigdata/test-fullvirt-serial-stdio.xml | 3 +++ .../test-fullvirt-serial-tcp-telnet.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-tcp.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-udp.xml | 3 +++ tests/xmconfigdata/test-fullvirt-serial-unix.xml | 3 +++ tests/xmconfigdata/test-fullvirt-sound.xml | 3 +++ tests/xmconfigdata/test-fullvirt-usbmouse.xml | 3 +++ .../test-fullvirt-usbtablet-no-bus.xml | 3 +++ tests/xmconfigdata/test-fullvirt-usbtablet.xml | 3 +++ tests/xmconfigdata/test-fullvirt-utc.xml | 3 +++ tests/xmconfigdata/test-no-source-cdrom.xml | 3 +++ tests/xmconfigdata/test-paravirt-net-e1000.xml | 1 + tests/xmconfigdata/test-paravirt-net-vifname.xml | 1 + .../test-paravirt-new-pvfb-vncdisplay.xml | 1 + tests/xmconfigdata/test-paravirt-new-pvfb.xml | 1 + .../test-paravirt-old-pvfb-vncdisplay.xml | 1 + tests/xmconfigdata/test-paravirt-old-pvfb.xml | 1 + tests/xmconfigdata/test-paravirt-vcpu.xml | 1 + tests/xmconfigdata/test-pci-devs.xml | 3 +++ tests/xmconfigtest.c | 3 ++- 103 files changed, 269 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 35d7fae89..e3d2eaf06 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2587,6 +2587,7 @@ libxlConnectDomainXMLFromNative(virConnectPtr conn, goto cleanup; if (!(def = xenParseXL(conf, cfg->caps, + driver->xmlopt, cfg->verInfo->xen_version_major))) goto cleanup; } else if (STREQ(nativeFormat, LIBXL_CONFIG_FORMAT_XM)) { @@ -2595,14 +2596,17 @@ libxlConnectDomainXMLFromNative(virConnectPtr conn, if (!(def = xenParseXM(conf, cfg->verInfo->xen_version_major, - cfg->caps))) + cfg->caps, + driver->xmlopt))) goto cleanup; } else if (STREQ(nativeFormat, LIBXL_CONFIG_FORMAT_SEXPR)) { /* only support latest xend config format */ if (!(def = xenParseSxprString(nativeConfig, XEND_CONFIG_VERSION_3_1_0, NULL, - -1))) { + -1, + cfg->caps, + driver->xmlopt))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("parsing sxpr config failed")); goto cleanup; diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index ce31f0f88..285a553ec 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -1645,7 +1645,8 @@ xenUnifiedConnectDomainXMLFromNative(virConnectPtr conn, if (!conf) goto cleanup; - def = xenParseXM(conf, priv->xendConfigVersion, priv->caps); + def = xenParseXM(conf, priv->xendConfigVersion, + priv->caps, priv->xmlopt); } else if (STREQ(format, XEN_CONFIG_FORMAT_SEXPR)) { if (xenGetDomIdFromSxprString(config, priv->xendConfigVersion, &id) < 0) goto cleanup; @@ -1654,7 +1655,7 @@ xenUnifiedConnectDomainXMLFromNative(virConnectPtr conn, vncport = xenStoreDomainGetVNCPort(conn, id); xenUnifiedUnlock(priv); def = xenParseSxprString(config, priv->xendConfigVersion, tty, - vncport); + vncport, priv->caps, priv->xmlopt); } if (!def) goto cleanup; diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 75f98b14e..00c63d328 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -139,7 +139,7 @@ xenXMConfigReadFile(virConnectPtr conn, const char *filename) if (!(conf = virConfReadFile(filename, 0))) return NULL; - def = xenParseXM(conf, priv->xendConfigVersion, priv->caps); + def = xenParseXM(conf, priv->xendConfigVersion, priv->caps, priv->xmlopt); virConfFree(conf); return def; diff --git a/src/xenconfig/xen_sxpr.c b/src/xenconfig/xen_sxpr.c index 7fc9c9d24..f9a3187f9 100644 --- a/src/xenconfig/xen_sxpr.c +++ b/src/xenconfig/xen_sxpr.c @@ -1491,7 +1491,11 @@ xenParseSxpr(const struct sexpr *root, */ virDomainDefPtr xenParseSxprString(const char *sexpr, - int xendConfigVersion, char *tty, int vncport) + int xendConfigVersion, + char *tty, + int vncport, + virCapsPtr caps, + virDomainXMLOptionPtr xmlopt) { struct sexpr *root = string2sexpr(sexpr); virDomainDefPtr def; @@ -1499,8 +1503,16 @@ xenParseSxprString(const char *sexpr, if (!root) return NULL; - def = xenParseSxpr(root, xendConfigVersion, NULL, tty, vncport); + if (!(def = xenParseSxpr(root, xendConfigVersion, NULL, tty, vncport))) + goto cleanup; + if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, + xmlopt) < 0) { + virDomainDefFree(def); + def = NULL; + } + + cleanup: sexpr_free(root); return def; diff --git a/src/xenconfig/xen_sxpr.h b/src/xenconfig/xen_sxpr.h index f354a50db..e42a93175 100644 --- a/src/xenconfig/xen_sxpr.h +++ b/src/xenconfig/xen_sxpr.h @@ -43,8 +43,12 @@ typedef enum { int xenGetDomIdFromSxprString(const char *sexpr, int xendConfigVersion, int *id); int xenGetDomIdFromSxpr(const struct sexpr *root, int xendConfigVersion, int *id); -virDomainDefPtr xenParseSxprString(const char *sexpr, int xendConfigVersion, - char *tty, int vncport); +virDomainDefPtr xenParseSxprString(const char *sexpr, + int xendConfigVersion, + char *tty, + int vncport, + virCapsPtr caps, + virDomainXMLOptionPtr xmlopt); virDomainDefPtr xenParseSxpr(const struct sexpr *root, int xendConfigVersion, const char *cpus, char *tty, int vncport); diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 0cb88cbcb..98e345c8b 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -444,7 +444,10 @@ xenParseXLInputDevs(virConfPtr conf, virDomainDefPtr def) } virDomainDefPtr -xenParseXL(virConfPtr conf, virCapsPtr caps, int xendConfigVersion) +xenParseXL(virConfPtr conf, + virCapsPtr caps, + virDomainXMLOptionPtr xmlopt, + int xendConfigVersion) { virDomainDefPtr def = NULL; @@ -469,6 +472,10 @@ xenParseXL(virConfPtr conf, virCapsPtr caps, int xendConfigVersion) if (xenParseXLInputDevs(conf, def) < 0) goto cleanup; + if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, + xmlopt) < 0) + goto cleanup; + return def; cleanup: diff --git a/src/xenconfig/xen_xl.h b/src/xenconfig/xen_xl.h index 983829741..58dfcb547 100644 --- a/src/xenconfig/xen_xl.h +++ b/src/xenconfig/xen_xl.h @@ -27,7 +27,9 @@ # include "domain_conf.h" # include "xen_common.h" -virDomainDefPtr xenParseXL(virConfPtr conn, virCapsPtr caps, +virDomainDefPtr xenParseXL(virConfPtr conn, + virCapsPtr caps, + virDomainXMLOptionPtr xmlopt, int xendConfigVersion); virConfPtr xenFormatXL(virDomainDefPtr def, virConnectPtr, int xendConfigVersion); diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index a4d1203fe..13eedf1e3 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -469,7 +469,8 @@ xenParseXMInputDevs(virConfPtr conf, virDomainDefPtr def) virDomainDefPtr xenParseXM(virConfPtr conf, int xendConfigVersion, - virCapsPtr caps) + virCapsPtr caps, + virDomainXMLOptionPtr xmlopt) { virDomainDefPtr def = NULL; @@ -491,6 +492,10 @@ xenParseXM(virConfPtr conf, if (xenParseXMInputDevs(conf, def) < 0) goto cleanup; + if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, + xmlopt) < 0) + goto cleanup; + return def; cleanup: diff --git a/src/xenconfig/xen_xm.h b/src/xenconfig/xen_xm.h index 629a4b326..61f94db8a 100644 --- a/src/xenconfig/xen_xm.h +++ b/src/xenconfig/xen_xm.h @@ -34,6 +34,6 @@ virConfPtr xenFormatXM(virConnectPtr conn, virDomainDefPtr def, int xendConfigVersion); virDomainDefPtr xenParseXM(virConfPtr conf, int xendConfigVersion, - virCapsPtr caps); + virCapsPtr caps, virDomainXMLOptionPtr xmlopt); #endif /* __VIR_XEN_XM_H__ */ diff --git a/tests/sexpr2xmldata/sexpr2xml-boot-grub.xml b/tests/sexpr2xmldata/sexpr2xml-boot-grub.xml index 1220407f3..ebce56692 100644 --- a/tests/sexpr2xmldata/sexpr2xml-boot-grub.xml +++ b/tests/sexpr2xmldata/sexpr2xml-boot-grub.xml @@ -23,5 +23,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml b/tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml index 25a29fd85..04445249a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml +++ b/tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml @@ -31,5 +31,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-curmem.xml b/tests/sexpr2xmldata/sexpr2xml-curmem.xml index 39d954a22..4ac263ed1 100644 --- a/tests/sexpr2xmldata/sexpr2xml-curmem.xml +++ b/tests/sexpr2xmldata/sexpr2xml-curmem.xml @@ -34,5 +34,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml b/tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml index 40e890390..18c7f4d36 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml @@ -29,5 +29,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-block.xml b/tests/sexpr2xmldata/sexpr2xml-disk-block.xml index 51e3b3a9d..cce8af1a4 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-block.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-block.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.xml b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.xml index 315c68a64..c61c0464a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.xml b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.xml index c56582da5..227e3bf1a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.xml b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.xml index 7afc6b50c..f74712b28 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-disk-file.xml b/tests/sexpr2xmldata/sexpr2xml-disk-file.xml index 36b8c1eb6..895605b25 100644 --- a/tests/sexpr2xmldata/sexpr2xml-disk-file.xml +++ b/tests/sexpr2xmldata/sexpr2xml-disk-file.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml b/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml index 761952cec..17e723ecc 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -47,5 +49,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml b/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml index 2898098db..9494ec2c8 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -40,5 +42,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml index a0fe30dd0..af1303bc9 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml @@ -25,6 +25,7 @@ +
@@ -32,6 +33,7 @@ +
@@ -43,5 +45,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml index 851797da6..406f3edba 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml @@ -25,6 +25,7 @@ +
@@ -32,6 +33,7 @@ +
@@ -43,5 +45,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml b/tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml index 09cfe19e8..572356420 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml @@ -28,5 +28,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml b/tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml index 44c0f6162..4f2a39b80 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml @@ -28,8 +28,10 @@ +
+ diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml b/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml index 29007f038..bc2ccecc7 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -40,5 +42,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml b/tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml index 3dbc999ce..ec75365b1 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -41,5 +43,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml b/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml index d96350ebe..f92ea4b2c 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -41,5 +43,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml index 7ad377c05..3bc6490ab 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -45,5 +47,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml index adba6cba3..d1b51343d 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -52,5 +54,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml index b6c36018d..1c5a0479c 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -48,5 +50,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml index dabe679d7..680528e07 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -48,5 +50,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml index fb19d740d..1a7f86695 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -46,5 +48,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml index 5aa425b32..b15a1bc6b 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -48,5 +50,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml index 3c2ca2109..e827f1d41 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -46,5 +48,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml index 160edbdb6..3d79428df 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -46,5 +48,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml index 4396efc42..7dec0c8fa 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -50,5 +52,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml index 3d17b5865..4f4b89b28 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -50,5 +52,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml index fc3d457f3..cf1fc3bea 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -50,5 +52,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml index 14b54f1b0..a1d15f526 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -48,5 +50,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml b/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml index 912df564b..4311b0cda 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -42,5 +44,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml b/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml index 912df564b..4311b0cda 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -42,5 +44,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml b/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml index 19eac3b06..103cfbe9e 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -41,5 +43,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml index 40ac8a97f..728e852b1 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -41,5 +43,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml b/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml index 97f2bebdb..7899baafa 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -40,5 +42,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml index 493d1b597..af5fbe1a2 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -40,5 +42,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-fv.xml b/tests/sexpr2xmldata/sexpr2xml-fv.xml index 97f2bebdb..7899baafa 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv.xml @@ -23,6 +23,7 @@ +
@@ -30,6 +31,7 @@ +
@@ -40,5 +42,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-net-bridged.xml b/tests/sexpr2xmldata/sexpr2xml-net-bridged.xml index ce7954dde..a6b765e1e 100644 --- a/tests/sexpr2xmldata/sexpr2xml-net-bridged.xml +++ b/tests/sexpr2xmldata/sexpr2xml-net-bridged.xml @@ -30,5 +30,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-net-e1000.xml b/tests/sexpr2xmldata/sexpr2xml-net-e1000.xml index 286209bee..631ca07be 100644 --- a/tests/sexpr2xmldata/sexpr2xml-net-e1000.xml +++ b/tests/sexpr2xmldata/sexpr2xml-net-e1000.xml @@ -31,5 +31,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-net-routed.xml b/tests/sexpr2xmldata/sexpr2xml-net-routed.xml index c03e40b09..5e1fbce4f 100644 --- a/tests/sexpr2xmldata/sexpr2xml-net-routed.xml +++ b/tests/sexpr2xmldata/sexpr2xml-net-routed.xml @@ -30,5 +30,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml index a3cd7be71..384ff8bfc 100644 --- a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml +++ b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml @@ -25,11 +25,13 @@ +
+
@@ -45,5 +47,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pci-devs.xml b/tests/sexpr2xmldata/sexpr2xml-pci-devs.xml index a404484b1..1dd00d5ad 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pci-devs.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pci-devs.xml @@ -34,5 +34,6 @@
+ diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml b/tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml index 0e92d0e95..a7cd3471d 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml b/tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml index bafe97fc8..6c1263629 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml @@ -23,5 +23,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml b/tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml index fc57fa938..c0ebf661d 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml index a55f83e6f..d1983cb4e 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml index 9ae7bff67..eacfc97de 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml @@ -29,5 +29,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml index c2eb798b5..f5b80c86c 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml @@ -29,5 +29,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-orig.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-orig.xml index c2eb798b5..f5b80c86c 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-orig.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-orig.xml @@ -29,5 +29,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml index 0fee41ced..0aebf2050 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml @@ -32,5 +32,6 @@ + diff --git a/tests/sexpr2xmldata/sexpr2xml-pv.xml b/tests/sexpr2xmldata/sexpr2xml-pv.xml index 36b8c1eb6..895605b25 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv.xml @@ -24,5 +24,6 @@ + diff --git a/tests/sexpr2xmltest.c b/tests/sexpr2xmltest.c index 99999f1e6..f7f61ccde 100644 --- a/tests/sexpr2xmltest.c +++ b/tests/sexpr2xmltest.c @@ -17,6 +17,7 @@ #define VIR_FROM_THIS VIR_FROM_NONE static virCapsPtr caps; +static virDomainXMLOptionPtr xmlopt; static int testCompareFiles(const char *xml, const char *sexpr, int xendConfigVersion) @@ -53,7 +54,8 @@ testCompareFiles(const char *xml, const char *sexpr, int xendConfigVersion) vncport = xenStoreDomainGetVNCPort(conn, id); xenUnifiedUnlock(&priv); - if (!(def = xenParseSxprString(sexprData, xendConfigVersion, tty, vncport))) + if (!(def = xenParseSxprString(sexprData, xendConfigVersion, + tty, vncport, caps, xmlopt))) goto fail; if (!virDomainDefCheckABIStability(def, def)) { @@ -116,6 +118,11 @@ mymain(void) if (!(caps = testXenCapsInit())) return EXIT_FAILURE; + if (!(xmlopt = xenDomainXMLConfInit())) { + virObjectUnref(caps); + return EXIT_FAILURE; + } + #define DO_TEST(in, out, version) \ do { \ struct testInfo info = { in, out, version }; \ @@ -186,6 +193,7 @@ mymain(void) DO_TEST("boot-grub", "boot-grub", 1); virObjectUnref(caps); + virObjectUnref(xmlopt); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml index 414f645b1..d59aa2126 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml @@ -27,12 +27,14 @@ +
+
diff --git a/tests/xlconfigdata/test-fullvirt-multiusb.xml b/tests/xlconfigdata/test-fullvirt-multiusb.xml index 642c2421b..0e6d0b6bd 100644 --- a/tests/xlconfigdata/test-fullvirt-multiusb.xml +++ b/tests/xlconfigdata/test-fullvirt-multiusb.xml @@ -24,12 +24,14 @@ +
+
diff --git a/tests/xlconfigdata/test-new-disk.xml b/tests/xlconfigdata/test-new-disk.xml index 1c96a62e5..718a2da00 100644 --- a/tests/xlconfigdata/test-new-disk.xml +++ b/tests/xlconfigdata/test-new-disk.xml @@ -24,17 +24,20 @@ +
+
+
diff --git a/tests/xlconfigdata/test-spice-features.xml b/tests/xlconfigdata/test-spice-features.xml index 8f3fcf5b1..3160c2b47 100644 --- a/tests/xlconfigdata/test-spice-features.xml +++ b/tests/xlconfigdata/test-spice-features.xml @@ -24,12 +24,14 @@ +
+
diff --git a/tests/xlconfigdata/test-spice.xml b/tests/xlconfigdata/test-spice.xml index e5b43d993..30415fb31 100644 --- a/tests/xlconfigdata/test-spice.xml +++ b/tests/xlconfigdata/test-spice.xml @@ -24,12 +24,14 @@ +
+
diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c index 952b50436..21f760d03 100644 --- a/tests/xlconfigtest.c +++ b/tests/xlconfigtest.c @@ -113,7 +113,7 @@ testCompareFormatXML(const char *xmcfg, const char *xml, int xendConfigVersion) if (!(conf = virConfReadMem(xmcfgData, strlen(xmcfgData), 0))) goto fail; - if (!(def = xenParseXL(conf, caps, xendConfigVersion))) + if (!(def = xenParseXL(conf, caps, xmlopt, xendConfigVersion))) goto fail; if (!(gotxml = virDomainDefFormat(def, VIR_DOMAIN_XML_INACTIVE | diff --git a/tests/xmconfigdata/test-escape-paths.xml b/tests/xmconfigdata/test-escape-paths.xml index 623eaa121..d2ec843dd 100644 --- a/tests/xmconfigdata/test-escape-paths.xml +++ b/tests/xmconfigdata/test-escape-paths.xml @@ -24,17 +24,20 @@ +
+
+
@@ -49,5 +52,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-default-feature.xml b/tests/xmconfigdata/test-fullvirt-default-feature.xml index 57a6531c4..06ad44eb8 100644 --- a/tests/xmconfigdata/test-fullvirt-default-feature.xml +++ b/tests/xmconfigdata/test-fullvirt-default-feature.xml @@ -26,12 +26,14 @@ +
+
@@ -44,5 +46,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-force-hpet.xml b/tests/xmconfigdata/test-fullvirt-force-hpet.xml index 57a6531c4..06ad44eb8 100644 --- a/tests/xmconfigdata/test-fullvirt-force-hpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-hpet.xml @@ -26,12 +26,14 @@ +
+
@@ -44,5 +46,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml b/tests/xmconfigdata/test-fullvirt-force-nohpet.xml index f6ebcf6dc..148c372f3 100644 --- a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-nohpet.xml @@ -26,12 +26,14 @@ +
+
@@ -44,5 +46,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-localtime.xml b/tests/xmconfigdata/test-fullvirt-localtime.xml index 36ab389ca..5db392cae 100644 --- a/tests/xmconfigdata/test-fullvirt-localtime.xml +++ b/tests/xmconfigdata/test-fullvirt-localtime.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-net-ioemu.xml b/tests/xmconfigdata/test-fullvirt-net-ioemu.xml index 3618baeb4..ad15ddef8 100644 --- a/tests/xmconfigdata/test-fullvirt-net-ioemu.xml +++ b/tests/xmconfigdata/test-fullvirt-net-ioemu.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-net-netfront.xml b/tests/xmconfigdata/test-fullvirt-net-netfront.xml index 6a2a43901..4d23802cd 100644 --- a/tests/xmconfigdata/test-fullvirt-net-netfront.xml +++ b/tests/xmconfigdata/test-fullvirt-net-netfront.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml b/tests/xmconfigdata/test-fullvirt-new-cdrom.xml index 3618baeb4..ad15ddef8 100644 --- a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml +++ b/tests/xmconfigdata/test-fullvirt-new-cdrom.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-old-cdrom.xml b/tests/xmconfigdata/test-fullvirt-old-cdrom.xml index 7d6014d01..dd5fd3f86 100644 --- a/tests/xmconfigdata/test-fullvirt-old-cdrom.xml +++ b/tests/xmconfigdata/test-fullvirt-old-cdrom.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml b/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml index 9b1fd268c..a2897f1fb 100644 --- a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml @@ -24,12 +24,14 @@ +
+
@@ -47,5 +49,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml b/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml index a64d40baa..5cbca37c5 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml @@ -24,12 +24,14 @@ +
+
@@ -54,5 +56,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml b/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml index ce2cddb7a..27c29c6c7 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml @@ -24,12 +24,14 @@ +
+
@@ -50,5 +52,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-file.xml b/tests/xmconfigdata/test-fullvirt-serial-file.xml index 36883def0..092c0628d 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-file.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-file.xml @@ -24,12 +24,14 @@ +
+
@@ -50,5 +52,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-null.xml b/tests/xmconfigdata/test-fullvirt-serial-null.xml index 982f9d60b..a1394d97f 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-null.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-null.xml @@ -24,12 +24,14 @@ +
+
@@ -48,5 +50,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml b/tests/xmconfigdata/test-fullvirt-serial-pipe.xml index 82a1d9b1e..321d309ec 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pipe.xml @@ -24,12 +24,14 @@ +
+
@@ -50,5 +52,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-pty.xml b/tests/xmconfigdata/test-fullvirt-serial-pty.xml index 56ccbeae3..05c82fe08 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pty.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pty.xml @@ -24,12 +24,14 @@ +
+
@@ -48,5 +50,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml b/tests/xmconfigdata/test-fullvirt-serial-stdio.xml index e2e933031..c6c702c7c 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-stdio.xml @@ -24,12 +24,14 @@ +
+
@@ -48,5 +50,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml b/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml index d68d77c06..72c169e03 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml @@ -24,12 +24,14 @@ +
+
@@ -52,5 +54,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml b/tests/xmconfigdata/test-fullvirt-serial-tcp.xml index aa3ed5c4d..ab179ecb0 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp.xml @@ -24,12 +24,14 @@ +
+
@@ -52,5 +54,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-udp.xml b/tests/xmconfigdata/test-fullvirt-serial-udp.xml index 256c7227f..8c8d19a63 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-udp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-udp.xml @@ -24,12 +24,14 @@ +
+
@@ -52,5 +54,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-serial-unix.xml b/tests/xmconfigdata/test-fullvirt-serial-unix.xml index 235c8d444..0e25cacb0 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-unix.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-unix.xml @@ -24,12 +24,14 @@ +
+
@@ -50,5 +52,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-sound.xml b/tests/xmconfigdata/test-fullvirt-sound.xml index 1429d1053..25364eb4d 100644 --- a/tests/xmconfigdata/test-fullvirt-sound.xml +++ b/tests/xmconfigdata/test-fullvirt-sound.xml @@ -24,12 +24,14 @@ +
+
@@ -44,5 +46,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-usbmouse.xml b/tests/xmconfigdata/test-fullvirt-usbmouse.xml index 25857f1d2..c7526ae62 100644 --- a/tests/xmconfigdata/test-fullvirt-usbmouse.xml +++ b/tests/xmconfigdata/test-fullvirt-usbmouse.xml @@ -24,12 +24,14 @@ +
+
@@ -43,5 +45,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-usbtablet-no-bus.xml b/tests/xmconfigdata/test-fullvirt-usbtablet-no-bus.xml index c82c8df42..23535eb70 100644 --- a/tests/xmconfigdata/test-fullvirt-usbtablet-no-bus.xml +++ b/tests/xmconfigdata/test-fullvirt-usbtablet-no-bus.xml @@ -24,12 +24,14 @@ +
+
@@ -41,5 +43,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-usbtablet.xml b/tests/xmconfigdata/test-fullvirt-usbtablet.xml index 31b11760b..aa16eb1b3 100644 --- a/tests/xmconfigdata/test-fullvirt-usbtablet.xml +++ b/tests/xmconfigdata/test-fullvirt-usbtablet.xml @@ -24,12 +24,14 @@ +
+
@@ -43,5 +45,6 @@ + diff --git a/tests/xmconfigdata/test-fullvirt-utc.xml b/tests/xmconfigdata/test-fullvirt-utc.xml index 3618baeb4..ad15ddef8 100644 --- a/tests/xmconfigdata/test-fullvirt-utc.xml +++ b/tests/xmconfigdata/test-fullvirt-utc.xml @@ -24,12 +24,14 @@ +
+
@@ -42,5 +44,6 @@ + diff --git a/tests/xmconfigdata/test-no-source-cdrom.xml b/tests/xmconfigdata/test-no-source-cdrom.xml index 74f1be18d..a0952e8ec 100644 --- a/tests/xmconfigdata/test-no-source-cdrom.xml +++ b/tests/xmconfigdata/test-no-source-cdrom.xml @@ -24,11 +24,13 @@ +
+
@@ -45,5 +47,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-net-e1000.xml b/tests/xmconfigdata/test-paravirt-net-e1000.xml index 346634423..0db020f04 100644 --- a/tests/xmconfigdata/test-paravirt-net-e1000.xml +++ b/tests/xmconfigdata/test-paravirt-net-e1000.xml @@ -32,5 +32,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-net-vifname.xml b/tests/xmconfigdata/test-paravirt-net-vifname.xml index 20d96aa38..ff17aee43 100644 --- a/tests/xmconfigdata/test-paravirt-net-vifname.xml +++ b/tests/xmconfigdata/test-paravirt-net-vifname.xml @@ -33,5 +33,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml b/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml index c02963d68..ce7bfb92e 100644 --- a/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml +++ b/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml @@ -31,5 +31,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-new-pvfb.xml b/tests/xmconfigdata/test-paravirt-new-pvfb.xml index ee255506c..cba6dffb8 100644 --- a/tests/xmconfigdata/test-paravirt-new-pvfb.xml +++ b/tests/xmconfigdata/test-paravirt-new-pvfb.xml @@ -31,5 +31,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-old-pvfb-vncdisplay.xml b/tests/xmconfigdata/test-paravirt-old-pvfb-vncdisplay.xml index c02963d68..ce7bfb92e 100644 --- a/tests/xmconfigdata/test-paravirt-old-pvfb-vncdisplay.xml +++ b/tests/xmconfigdata/test-paravirt-old-pvfb-vncdisplay.xml @@ -31,5 +31,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-old-pvfb.xml b/tests/xmconfigdata/test-paravirt-old-pvfb.xml index ee255506c..cba6dffb8 100644 --- a/tests/xmconfigdata/test-paravirt-old-pvfb.xml +++ b/tests/xmconfigdata/test-paravirt-old-pvfb.xml @@ -31,5 +31,6 @@ + diff --git a/tests/xmconfigdata/test-paravirt-vcpu.xml b/tests/xmconfigdata/test-paravirt-vcpu.xml index 52463d86e..3b0e0ce14 100644 --- a/tests/xmconfigdata/test-paravirt-vcpu.xml +++ b/tests/xmconfigdata/test-paravirt-vcpu.xml @@ -26,5 +26,6 @@ + diff --git a/tests/xmconfigdata/test-pci-devs.xml b/tests/xmconfigdata/test-pci-devs.xml index 191173422..bdb1e8262 100644 --- a/tests/xmconfigdata/test-pci-devs.xml +++ b/tests/xmconfigdata/test-pci-devs.xml @@ -24,11 +24,13 @@ +
+
@@ -55,5 +57,6 @@
+ diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c index 79b09cacc..804f9ee31 100644 --- a/tests/xmconfigtest.c +++ b/tests/xmconfigtest.c @@ -120,7 +120,8 @@ testCompareFormatXML(const char *xmcfg, const char *xml, int xendConfigVersion) if (!(conf = virConfReadMem(xmcfgData, strlen(xmcfgData), 0))) goto fail; - if (!(def = xenParseXM(conf, priv.xendConfigVersion, priv.caps))) + if (!(def = xenParseXM(conf, priv.xendConfigVersion, + caps, xmlopt))) goto fail; if (!(gotxml = virDomainDefFormat(def, VIR_DOMAIN_DEF_FORMAT_SECURE))) -- 2.39.5