From 90c2f8c3029a02813db4b416f6e1aeb2c0266cac Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Fri, 4 Apr 2014 11:13:32 +0200 Subject: [PATCH] tmem: remove dumb check in do_tmem_destroy_pool do_tmem_destroy_pool is checking if pools == NULL. But, pools is a fixed array. Clang 3.5 will fail to compile xen/common/tmem.c with the following error: tmem.c:1848:18: error: comparison of array 'client->pools' equal to a null pointer is always false [-Werror,-Wtautological-pointer-compare] if ( client->pools == NULL ) Coverity-ID:1055632 Signed-off-by: Julien Grall Acked-by: Konrad Rzeszutek Wilk (cherry picked from commit ac0f56a2fa407e0704fade12630a5a960dedce87) (cherry picked from commit 6ce0c3fca9bd1c0d45908452d6e5e9f7bf22f7b7) (cherry picked from commit 804d9af208c5c95156140b1c62cf8857ba250b03) --- xen/common/tmem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/common/tmem.c b/xen/common/tmem.c index 87542a9ec4..ae6a64477c 100644 --- a/xen/common/tmem.c +++ b/xen/common/tmem.c @@ -1874,8 +1874,6 @@ static NOINLINE int do_tmem_destroy_pool(uint32_t pool_id) client_t *client = tmh_client_from_current(); pool_t *pool; - if ( client->pools == NULL ) - return 0; if ( pool_id >= MAX_POOLS_PER_DOMAIN ) return 0; if ( (pool = client->pools[pool_id]) == NULL ) -- 2.39.5