From 8f9ccfe93570ecae18d9cc224931787d0bca9c66 Mon Sep 17 00:00:00 2001 From: Dario Faggioli Date: Fri, 16 Feb 2018 19:38:48 +0100 Subject: [PATCH] tools: libxenstat: fix format string overflow MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit With gcc 7.3.0, the build fails like this: src/xenstat_linux.c: In function ‘getBridge’ src/xenstat_linux.c:78:34: warning: ‘%s’ directive writing up to 255 bytes into a region of size 241 [-Wformat-overflow=] sprintf(tmp, "/sys/class/net/%s/bridge", de->d_name); ^~ src/xenstat_linux.c:78:5: note: ‘sprintf’ output between 23 and 278 bytes into a destination of size 256 sprintf(tmp, "/sys/class/net/%s/bridge", de->d_name); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix by making the buffer bigger. Signed-off-by: Dario Faggioli Acked-by: Wei Liu --- tools/xenstat/libxenstat/src/xenstat_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstat/libxenstat/src/xenstat_linux.c b/tools/xenstat/libxenstat/src/xenstat_linux.c index 907d65fa63..7cdd3bf91f 100644 --- a/tools/xenstat/libxenstat/src/xenstat_linux.c +++ b/tools/xenstat/libxenstat/src/xenstat_linux.c @@ -69,7 +69,7 @@ void getBridge(char *excludeName, char *result, size_t resultLen) struct dirent *de; DIR *d; - char tmp[256] = { 0 }; + char tmp[512] = { 0 }; d = opendir("/sys/class/net"); while ((de = readdir(d)) != NULL) { -- 2.39.5