From 898c257ba8b611a01bbcd1a88836a5d217ca9568 Mon Sep 17 00:00:00 2001 From: Stefan Hajnoczi Date: Tue, 7 Dec 2010 09:35:53 +0000 Subject: [PATCH] qemu-option: Don't reinvent append_option_parameters() parse_option_parameters() may need to create a new option parameter list from a template list. Use append_option_parameters() instead of duplicating the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-option.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 1f8f41ae7d..e380fc140d 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -416,20 +416,13 @@ QEMUOptionParameter *parse_option_parameters(const char *param, char value[256]; char *param_delim, *value_delim; char next_delim; - size_t num_options; if (list == NULL) { return NULL; } if (dest == NULL) { - // Count valid options - num_options = count_option_parameters(list); - - // Create a copy of the option list to fill in values - dest = qemu_mallocz((num_options + 1) * sizeof(QEMUOptionParameter)); - allocated = dest; - memcpy(dest, list, (num_options + 1) * sizeof(QEMUOptionParameter)); + dest = allocated = append_option_parameters(NULL, list); } while (*param) { -- 2.39.5