From 84fddfed45a2aadb06ba525f54de5dfd5834d44a Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Sat, 4 Jul 2020 23:43:52 -0400 Subject: [PATCH] libxl: eliminate extra copy of string MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit libxlMakeNic was calling g_strdup(virBufferCurrentContent(&buf)) to make a copy of the buffer contents, and then later freeing the buffer without ever using it again. Instead of this extra strdup, just transfer ownership of the virBuffer's string with virBufferContentAndReset(), and be done with it. Signed-off-by: Laine Stump Reviewed-by: Ján Tomko --- src/libxl/libxl_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 124e08d598..fe8ad4a3cb 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1335,7 +1335,7 @@ libxlMakeNic(virDomainDefPtr def, } } } - x_nic->bridge = g_strdup(virBufferCurrentContent(&buf)); + x_nic->bridge = virBufferContentAndReset(&buf); G_GNUC_FALLTHROUGH; case VIR_DOMAIN_NET_TYPE_ETHERNET: x_nic->script = g_strdup(script); -- 2.39.5