From 82c62c87347dd9b3acbc1ac94dc43663f52ac0aa Mon Sep 17 00:00:00 2001 From: George Dunlap Date: Sat, 22 Dec 2018 08:59:48 +0000 Subject: [PATCH] libxl/dm_depriv: Fix non-debug build Apparently older versions of gcc, when building with debug=n, the uninitialized variable logic gets confused. Distros on which a non-debug build will fail include: - Centos 7 - Debian Jessie - Ubuntu Trusty It seems to be one particular path confusing the logic; so just set it on that path to keep the compiler happy, while still catching other potential paths where it might be unset. Signed-off-by: George Dunlap --- tools/libxl/libxl_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 4b97936bd5..be493cf9f2 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -177,6 +177,7 @@ static int libxl__domain_get_device_model_uid(libxl__gc *gc, LOGD(DEBUG, guest_domid, "dm_restrict disabled, starting QEMU as root"); user = NULL; /* Should already be null, but just in case */ + kill_by_uid = false; /* Keep older versions of gcc happy */ rc = 0; goto out; } -- 2.39.5