From 82be0ffe63a1ad32ad582db9644cb83712dda8cb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Wed, 2 Feb 2022 11:43:09 +0000 Subject: [PATCH] conf: validate serial port model in ABI checks MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The serial port model cannot be allowed to change across migration as it affects ABI. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e931aef6c4..c8df6dcd4d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21094,6 +21094,14 @@ virDomainSerialDefCheckABIStability(virDomainChrDef *src, return false; } + if (src->targetModel != dst->targetModel) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target serial model %s does not match source %s"), + virDomainChrSerialTargetModelTypeToString(dst->targetModel), + virDomainChrSerialTargetModelTypeToString(src->targetModel)); + return false; + } + if (src->target.port != dst->target.port) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target serial port %d does not match source %d"), -- 2.39.5