From 7fb40ef26d82d2625fca89b2717cdb947f4a94aa Mon Sep 17 00:00:00 2001 From: Matthew Daley Date: Wed, 18 Sep 2013 15:37:57 +1200 Subject: [PATCH] mini-os: fix nodename generation in init_netfront Using strlen here makes no sense. Coverity-ID: 1056053 Signed-off-by: Matthew Daley Acked-by: Samuel Thibault --- netfront.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/netfront.c b/netfront.c index 4e087a5..a999985 100644 --- a/netfront.c +++ b/netfront.c @@ -309,8 +309,10 @@ struct netfront_dev *init_netfront(char *_nodename, void (*thenetif_rx)(unsigned if (!_nodename) snprintf(nodename, sizeof(nodename), "device/vif/%d", netfrontends); - else - strncpy(nodename, _nodename, strlen(nodename)); + else { + strncpy(nodename, _nodename, sizeof(nodename) - 1); + nodename[sizeof(nodename) - 1] = 0; + } netfrontends++; if (!thenetif_rx) -- 2.39.5