From 7e07c50dc0e979f21585e9ba61e8a0e77fc388fc Mon Sep 17 00:00:00 2001 From: Tim Wiederhake Date: Fri, 23 Apr 2021 17:39:17 +0200 Subject: [PATCH] virDomainGraphicsDefParseXML: Use virXMLProp* Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d57450b3c0..5cadbacea6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13230,25 +13230,13 @@ virDomainGraphicsDefParseXML(virDomainXMLOption *xmlopt, unsigned int flags) { virDomainGraphicsDef *def; - int typeVal; - g_autofree char *type = NULL; if (!(def = virDomainGraphicsDefNew(xmlopt))) return NULL; - type = virXMLPropString(node, "type"); - if (!type) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("missing graphics device type")); - goto error; - } - - if ((typeVal = virDomainGraphicsTypeFromString(type)) < 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown graphics device type '%s'"), type); + if (virXMLPropEnum(node, "type", virDomainGraphicsTypeFromString, + VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - } - def->type = typeVal; switch (def->type) { case VIR_DOMAIN_GRAPHICS_TYPE_VNC: -- 2.39.5