From 7c8004ef0cb699320161e2bb3bb10bafadd3f8d4 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 26 Sep 2016 17:20:36 +0200 Subject: [PATCH] VMX: don't bypass vmx_update_secondary_exec_control() While putting together another patch modifying the secondary exec controls I noticed that vmx_vcpu_update_vmfunc_ve() does a raw VMWRITE instead of going through the designated function. I assume that is not how it should be. Signed-off-by: Jan Beulich Acked-by: Kevin Tian --- xen/arch/x86/hvm/vmx/vmx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 50cbfed4dc..b9102cebed 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2062,9 +2062,7 @@ static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v) else v->arch.hvm_vmx.secondary_exec_control &= ~mask; - __vmwrite(SECONDARY_VM_EXEC_CONTROL, - v->arch.hvm_vmx.secondary_exec_control); - + vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); } -- 2.39.5