From 75fc9e692c602c528f82894a7a71ed0a3b46a51a Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 20 Feb 2025 13:50:19 +0100 Subject: [PATCH] x86/MCE-telem: adjust cookie definition struct mctelem_ent is opaque outside of mcetelem.c; the cookie abstraction exists - afaict - just to achieve this opaqueness. Then it is irrelevant though which kind of pointer mctelem_cookie_t resolves to. IOW we can as well use struct mctelem_ent there, allowing to remove the casts from COOKIE2MCTE() and MCTE2COOKIE(). Their removal addresses Misra C:2012 rule 11.2 ("Conversions shall not be performed between a pointer to an incomplete type and any other type") violations. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Release-Acked-By: Oleksii Kurochko --- xen/arch/x86/cpu/mcheck/mctelem.c | 4 ++-- xen/arch/x86/cpu/mcheck/mctelem.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c b/xen/arch/x86/cpu/mcheck/mctelem.c index 123e4102ad..ddd4c4cb7b 100644 --- a/xen/arch/x86/cpu/mcheck/mctelem.c +++ b/xen/arch/x86/cpu/mcheck/mctelem.c @@ -64,8 +64,8 @@ struct mctelem_ent { #define MC_NENT (MC_URGENT_NENT + MC_NONURGENT_NENT) -#define COOKIE2MCTE(c) ((struct mctelem_ent *)(c)) -#define MCTE2COOKIE(tep) ((mctelem_cookie_t)(tep)) +#define COOKIE2MCTE(c) (c) +#define MCTE2COOKIE(tep) (tep) static struct mc_telem_ctl { /* Linked lists that thread the array members together. diff --git a/xen/arch/x86/cpu/mcheck/mctelem.h b/xen/arch/x86/cpu/mcheck/mctelem.h index f4c5ff848d..31d02d9f88 100644 --- a/xen/arch/x86/cpu/mcheck/mctelem.h +++ b/xen/arch/x86/cpu/mcheck/mctelem.h @@ -52,7 +52,7 @@ * the element from the processing list. */ -typedef struct mctelem_cookie *mctelem_cookie_t; +typedef struct mctelem_ent *mctelem_cookie_t; typedef enum mctelem_class { MC_URGENT, -- 2.39.5