From 751554bfc9dc0363fabf882f6e8855022590ec4d Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Fri, 28 Jun 2013 12:25:57 +0100 Subject: [PATCH] xen/arm: gic_shutdown_irq must only disable the right IRQ When GICD_ICENABLERn is read, all the 1s bit represent enabled IRQs. Currently gic_shutdown_irq: - read GICD_ICENABLER - set the corresping bit to 1 - write back the new value That means, Xen will disable more IRQs than necessary. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Ian Campbell --- xen/arch/arm/gic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 177560e3d1..cafb68110a 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -117,12 +117,10 @@ static unsigned int gic_irq_startup(struct irq_desc *desc) static void gic_irq_shutdown(struct irq_desc *desc) { - uint32_t enabler; int irq = desc->irq; /* Disable routing */ - enabler = GICD[GICD_ICENABLER + irq / 32]; - GICD[GICD_ICENABLER + irq / 32] = enabler | (1u << (irq % 32)); + GICD[GICD_ICENABLER + irq / 32] = (1u << (irq % 32)); } static void gic_irq_enable(struct irq_desc *desc) -- 2.39.5