From 6ccd2501b42bd2c67904f30a4b5e515c06ce2255 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 21 Dec 2023 11:47:10 +0100 Subject: [PATCH] x86/mm: use "break" in arch_memory_op() The final return statement is unreachable and hence disliked by Misra C:2012 (rule 2.1). Convert those case-specific (main) return statements which already use "rc", or in one case when it can be used without further adding of code, to break. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/arch/x86/mm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0a66db10b9..b56e0d8065 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4724,7 +4724,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) spin_unlock(&d->arch.e820_lock); rcu_unlock_domain(d); - return rc; + break; } case XENMEM_memory_map: @@ -4818,7 +4818,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) if ( __copy_to_guest(arg, &ctxt.map, 1) ) return -EFAULT; - return 0; + break; } case XENMEM_machphys_mapping: @@ -4880,7 +4880,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) } rcu_unlock_domain(d); - return rc; + break; } #endif @@ -4888,7 +4888,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return subarch_memory_op(cmd, arg); } - return 0; + return rc; } int cf_check mmio_ro_emulated_write( -- 2.39.5