From 69979369bb8e1de8ad991f5756d9ee5f4bb3df0d Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Thu, 25 May 2017 09:35:58 -0400 Subject: [PATCH] nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild Should compare < 0 to be correct. Signed-off-by: John Ferlan --- src/conf/virnwfilterobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c index b5aaa6b0d4..0027d45b61 100644 --- a/src/conf/virnwfilterobj.c +++ b/src/conf/virnwfilterobj.c @@ -253,7 +253,7 @@ virNWFilterObjTestUnassignDef(virNWFilterObjPtr obj) obj->wantRemoved = true; /* trigger the update on VMs referencing the filter */ - if (virNWFilterTriggerVMFilterRebuild()) + if (virNWFilterTriggerVMFilterRebuild() < 0) rc = -1; obj->wantRemoved = false; @@ -345,7 +345,7 @@ virNWFilterObjListAssignDef(virNWFilterObjListPtr nwfilters, obj->newDef = def; /* trigger the update on VMs referencing the filter */ - if (virNWFilterTriggerVMFilterRebuild()) { + if (virNWFilterTriggerVMFilterRebuild() < 0) { obj->newDef = NULL; virNWFilterObjUnlock(obj); return NULL; -- 2.39.5