From 698b05d18dfe377abf07911dd1e9145c950f58c1 Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Thu, 15 Aug 2019 20:46:24 +0100 Subject: [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node() None of the code since the last check of res modify the value. So the check can be removed. Coverity-ID: 1476824 Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Reviewed-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 5709a77d4d..f049d0e7f9 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1661,8 +1661,7 @@ static int __init make_vpl011_uart_node(const struct domain *d, void *fdt) dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE, GUEST_PL011_SIZE); - if ( res ) - return res; + res = fdt_property(fdt, "reg", reg, sizeof(reg)); if ( res ) return res; -- 2.39.5