From 640b31535ab8fe07911d0b90ae4adbe6078026c9 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 13 Feb 2014 10:21:42 +0100 Subject: [PATCH] flask: check permissions first thing in flask_security_set_bool() Nothing else should be done if the caller isn't permitted to set boolean values. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Acked-by: Daniel De Graaf master commit: ebe867052e0f782139147015c4e91b37aa5e68f1 master date: 2014-02-11 11:14:10 +0100 --- xen/xsm/flask/flask_op.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c index 7d55f150d9..d60fbcaaac 100644 --- a/xen/xsm/flask/flask_op.c +++ b/xen/xsm/flask/flask_op.c @@ -326,11 +326,11 @@ static int flask_security_set_bool(struct xen_flask_boolean *arg) { int rv; - rv = flask_security_resolve_bool(arg); + rv = domain_has_security(current->domain, SECURITY__SETBOOL); if ( rv ) return rv; - rv = domain_has_security(current->domain, SECURITY__SETBOOL); + rv = flask_security_resolve_bool(arg); if ( rv ) return rv; -- 2.39.5