From 63cc969a845cf633d45df96a7fe7f79ee461cb7e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Fri, 20 Nov 2015 08:26:00 +0100 Subject: [PATCH] security_dac: check if virSecurityDACGetIds returns negative Use the customary check '< 0' instead of checking for non-zero. No functional change. --- src/security/security_dac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index cdde34ec2..6cb483949 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -547,7 +547,7 @@ virSecurityDACSetSecurityHostdevLabelHelper(const char *file, uid_t user; gid_t group; - if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL)) + if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0) return -1; return virSecurityDACSetOwnership(priv, NULL, file, user, group); @@ -1305,7 +1305,7 @@ virSecurityDACSetChildProcessLabel(virSecurityManagerPtr mgr, secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME); - if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL)) + if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0) return -1; VIR_DEBUG("Setting child to drop privileges to %u:%u", -- 2.39.5