From 5c53c93998e370ab3da0b3d1d12e6bc760224d67 Mon Sep 17 00:00:00 2001 From: Joshua Otto Date: Mon, 27 Mar 2017 05:06:22 -0400 Subject: [PATCH] libxc/xc_sr_save.c: initialise rec.data before free() colo_merge_secondary_dirty_bitmap() unconditionally free()s the .data member of its local xc_sr_record structure rec on its exit path. However, if the initial call to read_record() fails then this member is uninitialised. Initialise it. Signed-off-by: Joshua Otto Reviewed-by: Andrew Cooper Acked-by: Wei Liu --- tools/libxc/xc_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c index f98c8276d4..ca6913b723 100644 --- a/tools/libxc/xc_sr_save.c +++ b/tools/libxc/xc_sr_save.c @@ -520,7 +520,7 @@ static int send_memory_live(struct xc_sr_context *ctx) static int colo_merge_secondary_dirty_bitmap(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - struct xc_sr_record rec; + struct xc_sr_record rec = { 0, 0, NULL }; uint64_t *pfns = NULL; uint64_t pfn; unsigned count, i; -- 2.39.5