From 4e87164306f4bead094429ab9e520dfd1b58199f Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 19 Feb 2016 13:54:45 -0500 Subject: [PATCH] zfs: Resolve RESOURCE_LEAK Found by my Coverity checker - virCheckFlags call could return -1, but not virCommandFree(destroy_cmd). Signed-off-by: John Ferlan --- src/storage/storage_backend_zfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 6bf79634e1..4d04c70354 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -355,10 +355,12 @@ virStorageBackendZFSDeleteVol(virConnectPtr conn ATTRIBUTE_UNUSED, unsigned int flags) { int ret = -1; - virCommandPtr destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL); + virCommandPtr destroy_cmd = NULL; virCheckFlags(0, -1); + destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL); + virCommandAddArgFormat(destroy_cmd, "%s/%s", pool->def->source.name, vol->name); -- 2.39.5