From 4b4e8b57c2a652dd7e19c04d0b06c7a7e11e6f0c Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Tue, 3 May 2011 10:37:13 -0600 Subject: [PATCH] tests: avoid null pointer dereference Unlikely to hit in real life, but clang noticed it. * tests/commandtest.c (checkoutput, test4, test18): Avoid unlink(NULL) on OOM. --- tests/commandtest.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index fa0061cba1..caad69832a 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -78,7 +78,8 @@ static int checkoutput(const char *testname) ret = 0; cleanup: - unlink(actualname); + if (actualname) + unlink(actualname); VIR_FREE(actuallog); VIR_FREE(actualname); VIR_FREE(expectlog); @@ -240,7 +241,8 @@ static int test4(const void *unused ATTRIBUTE_UNUSED) cleanup: virCommandFree(cmd); - unlink(pidfile); + if (pidfile) + unlink(pidfile); VIR_FREE(pidfile); return ret; } @@ -703,7 +705,8 @@ static int test18(const void *unused ATTRIBUTE_UNUSED) cleanup: virCommandFree(cmd); - unlink(pidfile); + if (pidfile) + unlink(pidfile); VIR_FREE(pidfile); return ret; } -- 2.39.5