From 4a06cc7178ad8914dc2a0dc86282662af15041e1 Mon Sep 17 00:00:00 2001 From: Denis Mukhin Date: Tue, 26 Nov 2024 15:21:52 -0800 Subject: [PATCH] xsm/flask: missing breaks, MISRA rule 16.4 While working on console forwarding for virtual NS8250 I stepped into flask_domain_alloc_security() where break statement was missing in default case which violates MISRA rule 16.4. Fixed everywhere in hooks.c. Signed-off-by: Denis Mukhin Acked-by: Daniel P. Smith --- xen/xsm/flask/hooks.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index dfa23738cd..a79474ffe4 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -198,6 +198,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) else if ( pv_shim ) dsec->sid = SECINITSID_DOMU; } + break; } dsec->self_sid = dsec->sid; @@ -342,6 +343,7 @@ static int cf_check flask_evtchn_send(struct domain *d, struct evtchn *chn) break; default: rc = avc_unknown_permission("event channel state", chn->state); + break; } return rc; @@ -1310,6 +1312,7 @@ static int cf_check flask_hvm_param(struct domain *d, unsigned long op) break; default: perm = HVM__HVMCTL; + break; } return current_has_perm(d, SECCLASS_HVM, perm); @@ -2013,6 +2016,7 @@ const struct xsm_ops *__init flask_init( case FLASK_BOOTPARAM_INVALID: default: panic("Flask: Invalid value for flask= boot parameter.\n"); + break; } avc_init(); -- 2.39.5