From 3a89819de81661d1b2058b7bbc21e1d54ed67edf Mon Sep 17 00:00:00 2001 From: Alex Jia Date: Sun, 4 Sep 2011 23:48:41 +0800 Subject: [PATCH] tests: avoid memory leak on testTLSSessionInit * tests/virnettlscontexttest: fix memory leak on virnettlscontext test case. * Detected in valgrind run: ==25667== ==25667== 86,651 (34,680 direct, 51,971 indirect) bytes in 10 blocks are definitely lost in loss record 350 of 351 ==25667== at 0x4005447: calloc (vg_replace_malloc.c:467) ==25667== by 0x4F1F515D: gnutls_init (gnutls_state.c:270) ==25667== by 0x8053432: virNetTLSSessionNew (virnettlscontext.c:1181) ==25667== by 0x804DD24: testTLSSessionInit (virnettlscontexttest.c:624) ==25667== by 0x804F14D: virtTestRun (testutils.c:140) ==25667== ==25667== 100,578 (38,148 direct, 62,430 indirect) bytes in 11 blocks are definitely lost in loss record 351 of 351 ==25667== at 0x4005447: calloc (vg_replace_malloc.c:467) ==25667== by 0x4F1F515D: gnutls_init (gnutls_state.c:270) ==25667== by 0x8053432: virNetTLSSessionNew (virnettlscontext.c:1181) ==25667== by 0x804DD3C: testTLSSessionInit (virnettlscontexttest.c:625) ==25667== by 0x804F14D: virtTestRun (testutils.c:140) * How to reproduce? % cd libvirt && ./configure && make && make -C tests valgrind or % valgrind -v --leak-check=full ./tests/virnettlscontexttest Signed-off-by: Alex Jia --- tests/virnettlscontexttest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index ee7b6b4a6f..ece611a549 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -712,6 +712,8 @@ static int testTLSSessionInit(const void *opaque) cleanup: virNetTLSContextFree(serverCtxt); virNetTLSContextFree(clientCtxt); + virNetTLSSessionFree(serverSess); + virNetTLSSessionFree(clientSess); gnutls_x509_crt_deinit(data->careq.crt); if (data->othercareq.filename) gnutls_x509_crt_deinit(data->othercareq.crt); -- 2.39.5