From 37a265b93ac20145b0ad0c47b0496f3561b26741 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 18 Mar 2025 09:46:38 +0100 Subject: [PATCH] symbols: sanitize a few variable's types Parameter and return types of symbols_expand_symbol() make clear that xensyms_read()'s next_offset doesn't need to be 64-bit. xensyms_read()'s first parameter type makes clear that the function's next_symbols doesn't need to be 64-bit. symbols_num_syms'es type makes clear that iteration locals in symbols_lookup() don't need to be unsigned long (i.e. 64-bit on 64-bit architectures). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- xen/common/symbols.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/symbols.c b/xen/common/symbols.c index 133b580768..f8a7bde37b 100644 --- a/xen/common/symbols.c +++ b/xen/common/symbols.c @@ -108,7 +108,7 @@ const char *symbols_lookup(unsigned long addr, unsigned long *offset, char *namebuf) { - unsigned long i, low, high, mid; + unsigned int i, low, high, mid; unsigned long symbol_end = 0; const struct virtual_region *region; @@ -179,7 +179,7 @@ int xensyms_read(uint32_t *symnum, char *type, * from previous read. This can help us avoid the extra call to * get_symbol_offset(). */ - static uint64_t next_symbol, next_offset; + static unsigned int next_symbol, next_offset; static DEFINE_SPINLOCK(symbols_mutex); if ( *symnum > symbols_num_syms ) -- 2.39.5