From 379e63ed3da8f6d874d9bc5d6fa05a85afb60238 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Thu, 21 Jan 2010 15:13:00 +0000 Subject: [PATCH] x86: kill msix_flush_writes() The (only) two callers of it don't need it, as the MSI-X case of msi_set_mask_bit() already does the necessary readl(). Signed-off-by: Jan Beulich --- xen/arch/x86/msi.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 67f48a3555..06b53a202f 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -327,27 +327,6 @@ static void msix_set_enable(struct pci_dev *dev, int enable) } } -static void msix_flush_writes(unsigned int irq) -{ - struct msi_desc *entry = irq_desc[irq].msi_desc; - - BUG_ON(!entry || !entry->dev); - switch (entry->msi_attrib.type) { - case PCI_CAP_ID_MSI: - /* nothing to do */ - break; - case PCI_CAP_ID_MSIX: - { - int offset = PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET; - readl(entry->mask_base + offset); - break; - } - default: - BUG(); - break; - } -} - int msi_maskable_irq(const struct msi_desc *entry) { BUG_ON(!entry); @@ -409,13 +388,11 @@ static int msi_get_mask_bit(const struct msi_desc *entry) void mask_msi_irq(unsigned int irq) { msi_set_mask_bit(irq, 1); - msix_flush_writes(irq); } void unmask_msi_irq(unsigned int irq) { msi_set_mask_bit(irq, 0); - msix_flush_writes(irq); } static struct msi_desc* alloc_msi_entry(void) -- 2.39.5