From 2e85a83abee2982a7791e9b5d912af3799032bf6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Thu, 8 Apr 2021 13:57:55 +0100 Subject: [PATCH] meson: remove obsolete comment about stack frame size MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The virStrerror function no longer exists in libvirt so is not a constraint. At the current stack limit of 4k, and default Linux stack size of 8 MB, we have a recursion limit of 2048 in the absolute worst case, and much higher in common case. Even with smaller stack sizes, we're going to be fine as we don't deeply recurse in code. Thus it is not worth spending effort to optimize below our current 4k worst case limit. Removing the comment will stop encouraging people to spend time on this in future. Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrangé --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 5d49ca6489..dec46c4971 100644 --- a/meson.build +++ b/meson.build @@ -409,9 +409,6 @@ cc_flags += [ # but need to rewrite various areas of code first '-Wno-format-truncation', - # This should be < 256 really. Currently we're down to 4096, - # but using 1024 bytes sized buffers (mostly for virStrerror) - # stops us from going down further '-Wframe-larger-than=4096', # extra special flags -- 2.39.5