From 2dbe9c3cd2b2991cd65aad228b589a9bfb148b46 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 4 May 2017 15:04:29 +0200 Subject: [PATCH] x86/mm: silence a pointless warning get_page() logs a message when it fails (dom_cow is never dying or paging_mode_external()), so better avoid the call when it's pointless to do anyway. Signed-off-by: Jan Beulich Acked-by: George Dunlap Release-acked-by: Julien Grall --- xen/arch/x86/mm/p2m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 1d57e5c055..ae70a920b5 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -501,9 +501,9 @@ struct page_info *get_page_from_gfn_p2m( if ( fdom == NULL ) page = NULL; } - else if ( !get_page(page, d) + else if ( !get_page(page, d) && /* Page could be shared */ - && !get_page(page, dom_cow) ) + (!p2m_is_shared(*t) || !get_page(page, dom_cow)) ) page = NULL; } p2m_read_unlock(p2m); -- 2.39.5