From 2d93f78bfe25f695d8ffb61d110da9df293ed71b Mon Sep 17 00:00:00 2001 From: Nicola Vetrini Date: Tue, 28 May 2024 08:52:27 +0200 Subject: [PATCH] x86/traps: address violation of MISRA C Rule 8.4 Rule 8.4 states: "A compatible declaration shall be visible when an object or function with external linkage is defined". The function do_general_protection is either used is asm code or only within this unit, so there is no risk of this getting out of sync with its definition, but the function must remain extern. Therefore, this function is deviated using a comment-based deviation. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- xen/arch/x86/traps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 468a036081..9906e874d5 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1257,6 +1257,7 @@ void asmlinkage do_int3(struct cpu_user_regs *regs) pv_inject_hw_exception(X86_EXC_BP, X86_EVENT_NO_EC); } +/* SAF-1-safe */ void do_general_protection(struct cpu_user_regs *regs) { #ifdef CONFIG_PV -- 2.39.5